Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many servers do not send a meaningful hostname in 001 #288

Closed
ghost opened this issue Jan 11, 2015 · 5 comments
Closed

Many servers do not send a meaningful hostname in 001 #288

ghost opened this issue Jan 11, 2015 · 5 comments

Comments

@ghost
Copy link

ghost commented Jan 11, 2015

This was found during troubleshooting #286. On at least hybrid, perhaps other ircds, the 001 message does not include a meaningful hostmask for the user. This means that the max message length calculation is incorrect. We'll need to find a way to correctly calculate the value, possibly by issuing a WHOIS self.nick, likely in a registered event handler or something similar. I have seen a number of bots do this, and I know irssi does it at least. @jirwin, thoughts?

@ghost ghost added bug protocol labels Jan 11, 2015
@Trinitas
Copy link
Contributor

It says 001 message text used varies widely. Strange that people didn't mentioned this earlier.

@philip-peterson
Copy link
Contributor

We could do an rDNS lookup initially just to get a good guess, then if the server doesn't provide a good hostmask, do a WHOIS, perhaps?

@ghost
Copy link

ghost commented Sep 11, 2015

This is not closed, PR #386 was merged so this should be closed?

@LinuxMercedes
Copy link
Contributor

PR #386 hasn't been merged yet.

@jirwin
Copy link
Collaborator

jirwin commented Mar 26, 2016

Fixed #386

@jirwin jirwin closed this as completed Mar 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants