Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content warnings should show at the top of a post #357

Open
CorruptComputer opened this issue Nov 14, 2022 · 3 comments
Open

Content warnings should show at the top of a post #357

CorruptComputer opened this issue Nov 14, 2022 · 3 comments

Comments

@CorruptComputer
Copy link

On longer posts it can lead to your entire screen just being empty. This isn't a great UX.

Screenshot_2022-11-13-21-16-37-01_98181b3e65f153deb38599aee3aee7e4.jpg

Screenshot_2022-11-13-21-16-51-21_98181b3e65f153deb38599aee3aee7e4.jpg

@sk22
Copy link
Contributor

sk22 commented Nov 15, 2022

possible duplicate of #166, possible fix: master...sk22:mastodos:spoiler-height-independent

this would literally just take one changed line of code in TextStatusDisplayItem.java#L86

	spoilerOverlay.setVisibility(View.VISIBLE);
-	text.setVisibility(View.INVISIBLE);
+	text.setVisibility(View.GONE);
	itemView.setClickable(true);

@sk22
Copy link
Contributor

sk22 commented Nov 16, 2022

also consider: posts like this:
Screenshot_2022-11-16-21-12-16-281-edit_org joinmastodon android sk
the screenshot was taken with the single line code change in the comment above. if the hidden post was as tall as the post's content… well i wouldn't have fun scrolling down all the way

@waldyrious
Copy link

Instead of putting the text always on top (which would still produce the "blank screen" effect when scrolling down on long post), or changing the height of the post when hiding behind a spoiler tag (which would lead to sudden UI changes as a post is hidden/shown), perhaps a solution could be to use sticky positioning to keep the text in the center of the post height when that is visible on screen, and make it stick to the top or bottom of the screen when scrolling would move the center off-screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants