Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i18n to version 1.14.5 #30198

Merged
merged 3 commits into from
May 10, 2024
Merged

Update i18n to version 1.14.5 #30198

merged 3 commits into from
May 10, 2024

Conversation

mjankowski
Copy link
Contributor

Removes version lock from #29674

Issue ruby-i18n/i18n#688 was resolved in the release.

Previous failure example https://github.com/mastodon/mastodon/actions/runs/8337855263/job/22817285160

@mjankowski
Copy link
Contributor Author

Same failure still around, I suspect we need rails-i18n to bump as well. Renovate PR does same as this - #29679 - but this one removes the comment since the issue will be resolved.

@renchap
Copy link
Sponsor Member

renchap commented May 7, 2024

We probably need glebm/i18n-tasks#553 to be merged and updated at the same time for the action to be green

@mjankowski
Copy link
Contributor Author

Updated to point at github ref of fixed but not yet released fixed in i18n-tasks.

Assuming they release soon, will update to release version.

config/locales/uk.yml Outdated Show resolved Hide resolved
@mjankowski
Copy link
Contributor Author

Rebased and now using the released versions of both i18n and i18n-tasks. The rebase included the uk i18n escape interpolation fix as well, so I think CI should be good on next run here.

@renchap renchap enabled auto-merge May 10, 2024 12:34
@renchap renchap added this pull request to the merge queue May 10, 2024
Merged via the queue into mastodon:main with commit e20f2e7 May 10, 2024
31 checks passed
@mjankowski mjankowski deleted the fix-for-i18n branch May 10, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants