Skip to content

Commit

Permalink
[Side Sheet] Aligned close affordance and title text along the baseli…
Browse files Browse the repository at this point in the history
…ne rather than the top.

The close affordance icon and title text were previously aligned by the top. Since the icon button has extra spacing from insets and padding, the Views appeared to be misaligned. Aligning along the baseline fixes the visual misalignment.

This change is in the catalog since the side sheet view is provided by the developer.

PiperOrigin-RevId: 538570382
  • Loading branch information
afohrman authored and hunterstich committed Jun 9, 2023
1 parent 7ee0b72 commit 7a3f30b
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
app:icon="@drawable/ic_close_vd_theme_24px"
app:iconTint="?attr/colorOnSurfaceVariant"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="@id/side_sheet_title_text"
app:layout_constraintBaseline_toBaselineOf="@id/side_sheet_title_text"
tools:ignore="ContentDescription" />

<TextView
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
app:icon="@drawable/ic_close_vd_theme_24px"
app:iconTint="?attr/colorOnSurfaceVariant"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintBaseline_toBaselineOf="@id/coplanar_side_sheet_title_text"
tools:ignore="ContentDescription" />

<TextView
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
app:icon="@drawable/ic_close_vd_theme_24px"
app:iconTint="?attr/colorOnSurfaceVariant"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintBaseline_toBaselineOf="@id/coplanar_detached_side_sheet_title_text"
tools:ignore="ContentDescription" />

<TextView
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
app:icon="@drawable/ic_close_vd_theme_24px"
app:iconTint="?attr/colorOnSurfaceVariant"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintBaseline_toBaselineOf="@id/vertically_scrolling_side_sheet_title_text"
tools:ignore="ContentDescription" />

<TextView
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
app:icon="@drawable/ic_close_vd_theme_24px"
app:iconTint="?attr/colorOnSurfaceVariant"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="@id/detached_side_sheet_title_text"
app:layout_constraintBaseline_toBaselineOf="@id/detached_side_sheet_title_text"
tools:ignore="ContentDescription" />

<TextView
Expand Down

0 comments on commit 7a3f30b

Please sign in to comment.