-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SideSheet] Modal SideSheet Width #3492
Comments
@afohrman I'm thinking this is because of the hardcoded Line 44 in a16f180
I think we could consider moving that |
Or we could come up with a different API, because setting the width from sideSheetModalStyle might not be very natural, especially if there are multiple side sheets in the same app that need different widths. |
@dsn5ft any traction on this? |
I'll look into moving the width/height into sideSheetModalStyle so it can at least be customized somehow. |
##### Modal Side Sheet width를 조절하는 방법이 1.12.0-alpha03 버전부터 지원됨에 따라 Material Library 버전 업그레이드 - [관련 이슈](material-components/material-components-android#3492) - [문제가 해결된 커밋](material-components/material-components-android@3b278d7) etc - ImageButton 컴포넌트로 사용하던 아이콘 버튼을 Button 컴포넌트에 style을 입혀 Material 버튼 방식으로 변경
@dev210202 FATAL EXCEPTION: main |
@akeeaggarwal thanks for reporting this! The breakage is likely because I did take a look at your code though, and it seems like you're using a modal style rather than the standard one here and here. From what I can tell, it seems like you're trying to get a standard side sheet, in which case you'd want the |
@afohrman Thanks for your prompt response. Can you take a look on below implementation and suggest what I am doing wrong. This is how I am creating sidesheet by creating its object and setting the view from xml layout file - SideSheetDialog(ctx, R.style.SideSheet) This is my style - <style name="SideSheet" parent="ThemeOverlay.Material3.SideSheetDialog"> shapeAppearance"= @null enforceMaterialTheme = false android:layout_width" = 400dp </style>
But application is crashing. Can you suggest what I am doing wrong here? |
Description: Currently there is no way to change the Modal SideSheet width. It works for Standard and Coplanar Side Sheets.
Expected behavior: Modal SideSheet Dialog should respect the content layout width
Android API version: 33
Material Library version: 1.8.0
Device: Pixel C
The text was updated successfully, but these errors were encountered: