Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy heroku app for CI test #111

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

CasperWA
Copy link
Contributor

Closes #110

@CasperWA
Copy link
Contributor Author

I can't seem to get this to work as intended.
Anyone can feel free to take over.

@CasperWA
Copy link
Contributor Author

I can't seem to get this to work as intended. Anyone can feel free to take over.

It's working! Now the tests are failing "successfully", i.e., it reproduces the build error seen in other repositories that depend on this package.

CasperWA and others added 2 commits September 6, 2023 09:49
This was already removed, but re-added in this branch due to timing
issues between the branches.
@CasperWA
Copy link
Contributor Author

CasperWA commented Sep 6, 2023

It is my guess, that with the new build procedure (using the build library), if a new version is published, the accompanying binary wheel that will be uploaded should fix the installation issues for dependent packages - however, this is merely a guess and could be wrong.
BUT it can be tested by the new CI test introduced in this branch by simply creating a new release and then rerunning the CI tests here, checking and ensuring the newest version is fetched from PyPI, specifically for the CI - Build package / herokuish-build (pypi) job.

@CasperWA
Copy link
Contributor Author

CasperWA commented Sep 6, 2023

While tests seem to pass now it doesn't mean it's working as intended, unfortunately. Especially considering I cannot locate the templates in the template folders for Voilà and NBConvert. This means the post_install() function is not being run by pip install, which is bad.
Another solution needs to be made - either manually copying over the template by any users of the template or similar. This particular pathway can be made easier by making the post_install() functionality available through a command line script or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test building heroku container
1 participant