From d8031dccd045788ce1e6a82909fc3b987013c0a3 Mon Sep 17 00:00:00 2001 From: Tyler Mathis <35553152+tsmathis@users.noreply.github.com> Date: Mon, 9 Sep 2024 10:34:15 -0700 Subject: [PATCH] fix logic bug in batch_id validatoin --- emmet-core/emmet/core/tasks.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/emmet-core/emmet/core/tasks.py b/emmet-core/emmet/core/tasks.py index f1286d4459..1879be6667 100644 --- a/emmet-core/emmet/core/tasks.py +++ b/emmet-core/emmet/core/tasks.py @@ -487,11 +487,11 @@ def last_updated_dict_ok(cls, v) -> datetime: def _validate_batch_id(cls, v) -> str: if v is not None: invalid_chars = set( - char for char in v if (not char.isalnum()) or (char not in {"-", "_"}) + char for char in v if (not char.isalnum()) and (char not in {"-", "_"}) ) if len(invalid_chars) > 0: raise ValueError( - f"Invalid characters in batch_id:\n{' '.join(invalid_chars)}" + f"Invalid characters in batch_id: {' '.join(invalid_chars)}" ) return v