Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash not matching, (failing tests) seems related to matminer #155

Open
sgbaird opened this issue Jun 27, 2022 · 2 comments
Open

hash not matching, (failing tests) seems related to matminer #155

sgbaird opened this issue Jun 27, 2022 · 2 comments
Assignees

Comments

@sgbaird
Copy link
Contributor

sgbaird commented Jun 27, 2022

@ardunn tests are failing, seems related to matminer.
e.g.

======================================================================
ERROR: test_has_polymorphs (matbench.tests.test_task.TestMatbenchTask)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/matbench/matbench/matbench/tests/test_task.py", line 464, in test_has_polymorphs
    mbt = MatbenchTask("matbench_steels", autoload=True)
  File "/home/runner/work/matbench/matbench/matbench/task.py", line 89, in __init__
    self.df = load(self.dataset_name) if autoload else None
  File "/home/runner/work/matbench/matbench/matbench/data_ops.py", line 66, in load
    df = load_dataset(dataset_name)
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/matminer/datasets/dataset_retrieval.py", line 66, in load_dataset
    _validate_dataset(
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/matminer/datasets/utils.py", line 89, in _validate_dataset
    raise UserWarning(
UserWarning: Error, hash of downloaded file does not match that included in metadata, the data may be corrupt or altered
======================================================================
ERROR: test_instantiation (matbench.tests.test_task.TestMatbenchTask)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/matbench/matbench/matbench/tests/test_task.py", line 35, in test_instantiation
    MatbenchTask(ds, autoload=True)
  File "/home/runner/work/matbench/matbench/matbench/task.py", line 89, in __init__
    self.df = load(self.dataset_name) if autoload else None
  File "/home/runner/work/matbench/matbench/matbench/data_ops.py", line 66, in load
    df = load_dataset(dataset_name)
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/matminer/datasets/dataset_retrieval.py", line 66, in load_dataset
    _validate_dataset(
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/matminer/datasets/utils.py", line 89, in _validate_dataset
    raise UserWarning(
UserWarning: Error, hash of downloaded file does not match that included in metadata, the data may be corrupt or altered
======================================================================
ERROR: test_record (matbench.tests.test_task.TestMatbenchTask)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/matbench/matbench/matbench/tests/test_task.py", line 211, in test_record
    mbt.load()
  File "/home/runner/work/matbench/matbench/matbench/task.py", line 235, in load
    self.df = load(self.dataset_name)
  File "/home/runner/work/matbench/matbench/matbench/data_ops.py", line 66, in load
    df = load_dataset(dataset_name)
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/matminer/datasets/dataset_retrieval.py", line 66, in load_dataset
    _validate_dataset(
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/matminer/datasets/utils.py", line 89, in _validate_dataset
    raise UserWarning(
UserWarning: Error, hash of downloaded file does not match that included in metadata, the data may be corrupt or altered
----------------------------------------------------------------------
Ran 30 tests in 73.[767](https://github.com/materialsproject/matbench/runs/6874143276?check_suite_focus=true#step:4:768)s

Originally posted by @sgbaird in #152 (comment)

@sgbaird
Copy link
Contributor Author

sgbaird commented Jun 27, 2022

Causing some downstream issues in CrabNet CI, too, https://github.com/sparks-baird/CrabNet/runs/7081532854?check_suite_focus=true

@ardunn
Copy link
Collaborator

ardunn commented Aug 13, 2022

Note to self: caused by matminer downloading datasets from figshare and likely CI IP being blocked/rate limited or some other CI-specific nonsense; can likely be fixed by trying download and if it fails retrying after some set amount of time (or just including this in the matminer core code for load_dataset)

@ardunn ardunn self-assigned this Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants