Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convention naming update #7016

Open
liviuconcioiu opened this issue Feb 26, 2022 · 6 comments
Open

Convention naming update #7016

liviuconcioiu opened this issue Feb 26, 2022 · 6 comments

Comments

@liviuconcioiu
Copy link
Collaborator

An update should be made to convention naming, because right now there are a few devices like:

Galaxy Tab A7 Lite 8.7" (2021) WiFi
Galaxy Tab A 10.1" WiFi (2016)

@sanchezzzhak
Copy link
Collaborator

it's a good idea, I suggest such formats

Format Table
<model name> <screen size>"? (Year)? <network type>(LTE|3G|4G|WiFi|5G)?

Good:

  • Galaxy Tab A7 Lite 8.7" (2021) LTE
  • Galaxy Tab A 10.1" (2016) WiFi
  • Galaxy Tab A7 Lite 8.7" (2021) WiFi
  • Galaxy Tab A7 Lite 8.7" (2020-2021) WiFi
  • Galaxy Tab Active 8" WiFi
  • MatePad Pro 10.8" 5G

Bad:

  • Galaxy Tab A 10.1" WiFi (2016)
  • Galaxy Tab A 10.1" LTE (2016)
  • Galaxy Tab A LTE (2016)
  • Galaxy Tab A LTE 10.1"

Format Watch
<model name> <screen size>mm? (Year)? <network type>(LTE|3G|4G|WiFi|5G)?

Good:
Galaxy Watch Active 2 44mm LTE

@sgiehl
Copy link
Member

sgiehl commented Feb 26, 2022

Sounds good. Feel free to also create some tests, that ensure e.g. parts like LTE are in the end

@liviuconcioiu
Copy link
Collaborator Author

RAM should also be added Allview A10 Lite 2GB

@sgiehl
Copy link
Member

sgiehl commented Mar 2, 2022

I actually would vote for not adding details about RAM to the name. Otherwise we end up having too many detected devices.
The network type might already be not relevant for most people...

@liviuconcioiu
Copy link
Collaborator Author

    - regex: '(?:Sony(?:Ericsson)?)?D2302'
      model: 'Xperia M2 Dual'
    - regex: 'K00Z(?:[);/ ]|$)'
      model: 'Fonepad 7 Dual SIM'
      device: 'phablet'

@sgiehl
Copy link
Member

sgiehl commented Mar 2, 2022

Hm... The Dual SIM might actually be kind of not relevant as well. Not sure if we should keep or maybe remove, unless it's part of the official marketing name maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@sanchezzzhak @sgiehl @liviuconcioiu and others