[PHP 8.4] Explicitly mark nullable parameters #22693
Merged
+136
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you use a tool to convert the params or did you do it manually? |
| @@ -174,7 +174,7 @@ public function getPrettyPercentFromQuotient($value) | |||
| * This parameter is not currently supported and subject to change. | |||
| * @api | |||
| */ | |||
| public function formatMetrics(DataTable $dataTable, Report $report = null, $metricsToFormat = null, $formatAll = false) | |||
| public function formatMetrics(DataTable $dataTable, ?Report $report = null, $metricsToFormat = null, $formatAll = false) | |||
There was a problem hiding this comment.
It's annoying we can't use mixed or union type here yet, however it looks like this can be typed to array based on its use?
| @@ -174,7 +174,7 @@ public function getPrettyPercentFromQuotient($value) | |||
| * This parameter is not currently supported and subject to change. | |||
| * @api | |||
| */ | |||
| public function formatMetrics(DataTable $dataTable, Report $report = null, $metricsToFormat = null, $formatAll = false) | |||
| public function formatMetrics(DataTable $dataTable, ?Report $report = null, $metricsToFormat = null, $formatAll = false) | |||
There was a problem hiding this comment.
Suggested change
| public function formatMetrics(DataTable $dataTable, ?Report $report = null, $metricsToFormat = null, $formatAll = false) | |
| public function formatMetrics(DataTable $dataTable, ?Report $report = null, ?array $metricsToFormat = null, $formatAll = false) |
| @@ -61,7 +61,7 @@ class Updater | |||
| * for the plugin name. | |||
| * @param Columns\Updater|null $columnsUpdater The dimensions updater instance. | |||
| */ | |||
| public function __construct($pathUpdateFileCore = null, $pathUpdateFilePlugins = null, Columns\Updater $columnsUpdater = null) | |||
| public function __construct($pathUpdateFileCore = null, $pathUpdateFilePlugins = null, ?Columns\Updater $columnsUpdater = null) | |||
There was a problem hiding this comment.
Suggested change
| public function __construct($pathUpdateFileCore = null, $pathUpdateFilePlugins = null, ?Columns\Updater $columnsUpdater = null) | |
| public function __construct(?string $pathUpdateFileCore = null, ?string $pathUpdateFilePlugins = null, ?Columns\Updater $columnsUpdater = null) |
|
@michalkleiner I actually used a regex to find those and fixed them manually. Might be possible that I missed some though. |
Implicit nullable typed value. Fair enough. |
michalkleiner
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With PHP 8.4 implicitly marking parameters as nullable by only setting null as default value is deprecated.
To get rid of all the deprecation notices caused by our code, this PR aims to change all occurrences to explicitly mark the parameters as nullable.
refs #22471
Review