Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates marketplace icons with higher contrast version, #PG-3668 #22699

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Updates marketplace icons with higher contrast version
Fixes: #PG-3668

Review

@AltamashShaikh
Copy link
Contributor Author

@michalkleiner Do we need to update the icons in any other place apart from marketplace code ?

@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Oct 18, 2024
@AltamashShaikh
Copy link
Contributor Author

Will update the UI tests when #22698 is merged as both aims to update same set of screenshots

michalkleiner
michalkleiner previously approved these changes Oct 18, 2024
@michalkleiner michalkleiner dismissed their stale review October 18, 2024 10:06

Still needs UI test change

@michalkleiner
Copy link
Contributor

@AltamashShaikh I think these are all the places where the icons are used in core.

@AltamashShaikh
Copy link
Contributor Author

@AltamashShaikh I think these are all the places where the icons are used in core.

@michalkleiner Done, good to merge if test cases are passing.

@michalkleiner michalkleiner added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Oct 18, 2024
@michalkleiner michalkleiner added this to the 5.2.0 milestone Oct 18, 2024
@michalkleiner michalkleiner merged commit 920034b into 5.x-dev Oct 18, 2024
26 checks passed
@michalkleiner michalkleiner deleted the PG-3668-update-icons branch October 18, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants