This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
Don't check the mimetype via content.file.mimetype #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is not actually specced. The specced field is at content.info.mimetype, which isn't currently sent to the content scanner. We check the mimetype of the file by scanning it. As issue #49 mentions, this check is not infallible, but that should be fixed separately.
jaywink
approved these changes
Aug 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50.
This field is not actually specced. The specced field is at content.info.mimetype, which isn't currently sent to the content scanner.
We check the mimetype of the file by scanning the file itself. As issue #49 mentions, this check is not infallible, but that should be fixed separately.