-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EncryptedFile examples containing mimetype #569
Comments
The original intention was that the mimetype is supposed to be duplicated, but was accidentally omitted when that was originally merged. However, MSC2582 is a proposal to drop the field. |
Following on from matrix-org/matrix-spec-proposals#2699:
I'm not sure I'm following. The property in question is not, itself, encrypted - it just describes the data that is. Doesn't that make it something that the homeserver should be concerned about the validity of? |
No, this applies only to encrypted events and since this is in content and not a relation, it is encrypted and the homeserver can't see it at all. |
For posterity: after a brief chat with @deepbluev7 it turned out that the bit I overlooked was that the entire media event is getting encrypted, and so the homeserver never sees any of it, and that is why it can't be validated. It's clear now :) |
While looking at the spec of the EncryptedFile needed for attachment encryption, I noticed that all the examples contain a mimetype field, which is duplicated from the info subobject. The specification for EncryptedFile doesn't list that as an optional member though. Riot also seems to send this additional mimetype. So I'm wondering, should that be in the spec, are the examples wrong and why even is that field duplicated?
The text was updated successfully, but these errors were encountered: