Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index content repository content consistently by hash (SPEC-140) #34

Open
matrixbot opened this issue Mar 29, 2015 · 5 comments
Open

Index content repository content consistently by hash (SPEC-140) #34

matrixbot opened this issue Mar 29, 2015 · 5 comments
Labels
A-Client-Server Issues affecting the CS API feature Suggestion for a significant extension which needs considerable consideration p2

Comments

@matrixbot
Copy link
Member

In pre-Matrix stuff we always indexed and referred to binary content by its hashcode. This magically factored out duplicate content in server-side content repos. If we did this in Matrix we'd also avoid filling up diskspace with hundreds of identical cat GIFs; it's unclear why we don't?

(Imported from https://matrix.org/jira/browse/SPEC-140)

(Reported by @ara4n)
@matrixbot
Copy link
Member Author

Jira watchers: @ara4n

@matrixbot
Copy link
Member Author

matrixbot commented Mar 29, 2015 •
edited
Loading

Links exported from Jira:

relates to SYN-401

@matrixbot matrixbot added the p2 label Oct 28, 2016
@matrixbot matrixbot changed the title Index content repository content consistently by hash Index content repository content consistently by hash (SPEC-140) Oct 31, 2016
@matrixbot matrixbot added the feature Suggestion for a significant extension which needs considerable consideration label Nov 7, 2016
@ara4n ara4n mentioned this issue Jan 21, 2017
Closed
@turt2live
Copy link
Member

This is also possible as an implementation detail. For instance, matrix-media-repo (a project of mine) achieves this by storing a 1:many relationship of files to mxc uris. This allows mxc://t2bot.io/whatever1 and mxc://t2bot.io/whatever2 to point to the same file on disk (which is indexed by hash). It also goes the extra mile and will try to re-use mxc uris on upload.

@richvdh
Copy link
Member

richvdh commented Mar 5, 2018

agreed, I'd favour keeping it as an impl detail

@richvdh richvdh closed this as completed Mar 5, 2018
@richvdh richvdh reopened this Mar 5, 2018
@richvdh
Copy link
Member

richvdh commented Mar 5, 2018

didn't mean to close it yet!

@turt2live turt2live added the A-Client-Server Issues affecting the CS API label Feb 6, 2019
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Client-Server Issues affecting the CS API feature Suggestion for a significant extension which needs considerable consideration p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @richvdh @matrixbot