Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can "request" be switched with, "node-fetch" within this sdk? #2570

Closed
tearfulnumpty opened this issue Aug 7, 2022 · 2 comments
Closed

Can "request" be switched with, "node-fetch" within this sdk? #2570

tearfulnumpty opened this issue Aug 7, 2022 · 2 comments

Comments

@tearfulnumpty
Copy link

tearfulnumpty commented Aug 7, 2022

Is your feature request related to a problem? Please describe.
The request npm package is deprecated as of ~two years ago. It is used in the matrix-js-sdk for various workarounds.

Describe the solution you'd like
A swap of "request" over to "node-fetch" would be great for a workaround to the above problem #2415

Describe alternatives you've considered
In place of matrix-js-sdk relying on node-fetch, if it was possible to avoid the above error from #2415 without using request, this could be a valid solution depending on the exact solution found.

Additional context
Work is being done to create a matrix plugin for the Shinobi CCTV NVR software project. Notifications from events (such as motion detection on a security camera) are to be sent to a Matrix server from Shinobi, using the matrix-js-sdk as a sort of, "plugin" for Shinobi. The error mentioned above at #2415 appears without the added workaround in place. Due to the deprecated status of the request package, the developer of Shinobi would like to avoid using it in favor of the node-fetch package.


Thanks for your time! I appreciate it a lot.

@moeiscool
Copy link

I second this, I would really like to include Matrix Notifications in Shinobi but cannot unless request is removed :( Thank you for considering this change.

@t3chguy
Copy link
Member

t3chguy commented Aug 8, 2022

Duplicate of #801

@t3chguy t3chguy marked this as a duplicate of #801 Aug 8, 2022
@t3chguy t3chguy closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants