Lazy loading: don't assume we have our own member available #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works with rooms which haven't had their members loaded yet.
…mary heroes/counts.
bwindels
changed the title
|
Perhaps a bit controversial, but I moved the syncing user id into room, as it makes it makes room more self-contained, the methods getMyMembership and recalculate don't need a user id anymore, which I think makes sense. Also less logic in react-sdk like this. Let me know what you think. |
22 tasks
6 tasks
dbkr
approved these changes
Aug 3, 2018
|
@dbkr The room constructor is called once from react-sdk (from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.