Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually construct query strings for browser-request instances #770

Merged
merged 5 commits into from
Oct 30, 2018
Merged

Manually construct query strings for browser-request instances #770

merged 5 commits into from
Oct 30, 2018

Commits on Oct 30, 2018

  1. Manually construct query strings for browser-request instances 

    Because `request` just doesn't work for us in the browser, but `browser-request` is fine despite us having to do our own query strings.

Fixes element-hq/element-web#7620
    @turt2live
    turt2live committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    f288112 View commit details
    Browse the repository at this point in the history

  2. Because uglify-js breaks everything

    @turt2live
    turt2live committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    68b65dd View commit details
    Browse the repository at this point in the history

  3. Just use the interface provided to us rather than hack in a flag

    @turt2live
    turt2live committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    054aac1 View commit details
    Browse the repository at this point in the history

  4. We can't use arrow functions, apparently.

    @turt2live
    turt2live committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    b57e858 View commit details
    Browse the repository at this point in the history

  5. Use the right query string lib

    @turt2live
    turt2live committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    2fb29ae View commit details
    Browse the repository at this point in the history