From 2ec8a32641e905b71300690a34d66c1a72bb1c42 Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Wed, 16 Feb 2022 22:47:27 +0000 Subject: [PATCH] Fix more bugs identified --- src/components/structures/TimelinePanel.tsx | 4 ++-- src/components/views/rooms/EventTile.tsx | 5 +++-- src/components/views/rooms/MemberTile.tsx | 7 ++++--- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/components/structures/TimelinePanel.tsx b/src/components/structures/TimelinePanel.tsx index 10740456f9d..feefb999618 100644 --- a/src/components/structures/TimelinePanel.tsx +++ b/src/components/structures/TimelinePanel.tsx @@ -677,11 +677,11 @@ class TimelinePanel extends React.Component { this.forceUpdate(); }; - private onEventReplaced = (replacedEvent: MatrixEvent, room: Room): void => { + private onEventReplaced = (replacedEvent: MatrixEvent): void => { if (this.unmounted) return; // ignore events for other rooms - if (room !== this.props.timelineSet.room) return; + if (replacedEvent.getRoomId() !== this.props.timelineSet.room.roomId) return; // we could skip an update if the event isn't in our timeline, // but that's probably an early optimisation. diff --git a/src/components/views/rooms/EventTile.tsx b/src/components/views/rooms/EventTile.tsx index c9d5f7dc9d1..c6e6812d5fa 100644 --- a/src/components/views/rooms/EventTile.tsx +++ b/src/components/views/rooms/EventTile.tsx @@ -26,6 +26,8 @@ import { logger } from "matrix-js-sdk/src/logger"; import { NotificationCountType, Room, RoomEvent } from 'matrix-js-sdk/src/models/room'; import { CallErrorCode } from "matrix-js-sdk/src/webrtc/call"; import { M_POLL_START } from "matrix-events-sdk"; +import { CryptoEvent } from "matrix-js-sdk/src/crypto"; +import { UserTrustLevel } from 'matrix-js-sdk/src/crypto/CrossSigning'; import ReplyChain from "../elements/ReplyChain"; import { _t } from '../../../languageHandler'; @@ -78,7 +80,6 @@ import { copyPlaintext } from '../../../utils/strings'; import { DecryptionFailureTracker } from '../../../DecryptionFailureTracker'; import RedactedBody from '../messages/RedactedBody'; import { ViewRoomPayload } from "../../../dispatcher/payloads/ViewRoomPayload"; -import { CryptoEvent } from "matrix-js-sdk/src/crypto"; const eventTileTypes = { [EventType.RoomMessage]: 'messages.MessageEvent', @@ -765,7 +766,7 @@ export default class EventTile extends React.Component { } }; - private onUserVerificationChanged = (userId: string, _trustStatus: string): void => { + private onUserVerificationChanged = (userId: string, _trustStatus: UserTrustLevel): void => { if (userId === this.props.mxEvent.getSender()) { this.verifyEvent(this.props.mxEvent); } diff --git a/src/components/views/rooms/MemberTile.tsx b/src/components/views/rooms/MemberTile.tsx index 13fba7561f8..36d6555d210 100644 --- a/src/components/views/rooms/MemberTile.tsx +++ b/src/components/views/rooms/MemberTile.tsx @@ -21,6 +21,9 @@ import { MatrixEvent } from "matrix-js-sdk/src/models/event"; import { EventType } from "matrix-js-sdk/src/@types/event"; import { DeviceInfo } from "matrix-js-sdk/src/crypto/deviceinfo"; import { UserEvent } from "matrix-js-sdk/src/models/user"; +import { CryptoEvent } from "matrix-js-sdk/src/crypto"; +import { RoomStateEvent } from "matrix-js-sdk/src/models/room-state"; +import { UserTrustLevel } from 'matrix-js-sdk/src/crypto/CrossSigning'; import SettingsStore from "../../../settings/SettingsStore"; import dis from "../../../dispatcher/dispatcher"; @@ -31,8 +34,6 @@ import { replaceableComponent } from "../../../utils/replaceableComponent"; import EntityTile, { PowerStatus } from "./EntityTile"; import MemberAvatar from "./../avatars/MemberAvatar"; import UserIdentifierCustomisations from '../../../customisations/UserIdentifier'; -import { CryptoEvent } from "matrix-js-sdk/src/crypto"; -import { RoomStateEvent } from "matrix-js-sdk"; interface IProps { member: RoomMember; @@ -120,7 +121,7 @@ export default class MemberTile extends React.Component { this.updateE2EStatus(); }; - private onUserTrustStatusChanged = (userId: string, trustStatus: string): void => { + private onUserTrustStatusChanged = (userId: string, trustStatus: UserTrustLevel): void => { if (userId !== this.props.member.userId) return; this.updateE2EStatus(); };