Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Lazy load room members - Part I #2072

Merged
merged 19 commits into from
Jul 26, 2018
Merged

Lazy load room members - Part I #2072

merged 19 commits into from
Jul 26, 2018

Commits on Jul 25, 2018

  1. [WIP] Send lazy_load_memberers filter when syncing

    @lukebarnard1 @bwindels
    lukebarnard1 authored and bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    a11e1cc View commit details
    Browse the repository at this point in the history

  2. ask client to lazy load room members when viewing a room

    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    8c985bd View commit details
    Browse the repository at this point in the history

  3. only lazy load the members when viewing a joined room

    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    de3e143 View commit details
    Browse the repository at this point in the history

  4. Don't assume RoomMember has a state event in direct chat detection 

    Instead call the method on the member that takes lazy loading into account
    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    1938780 View commit details
    Browse the repository at this point in the history

  5. this code actually never fires, so remove it 

    and that's ok because createRoom will already mark a DM as such
on the inviter's side. So here we just handle the invitees side.
    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    6ff92ed View commit details
    Browse the repository at this point in the history

  6. use member helper method instead of digging inside member

    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    54904c9 View commit details
    Browse the repository at this point in the history

  7. use more consistent naming

    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    e237a02 View commit details
    Browse the repository at this point in the history

  8. use helper method for knowing whether a user was kicked 

    mainly for readability, but also to discourage grabbing into the member
because of lazy loading changes
    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    8529bc5 View commit details
    Browse the repository at this point in the history

  9. don't assume a member has events associated

    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    af77f02 View commit details
    Browse the repository at this point in the history

  10. take into account lazy loading when enlarging avatar

    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    8c9ceca View commit details
    Browse the repository at this point in the history

  11. use isKicked method in preview bar

    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    866b4bb View commit details
    Browse the repository at this point in the history

  12. hide lazy loading behind feature flag

    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    af07d73 View commit details
    Browse the repository at this point in the history

  13. move comment after rebase

    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    201332d View commit details
    Browse the repository at this point in the history

  14. fix tests

    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    34cb89e View commit details
    Browse the repository at this point in the history

  15. move error message to caller of lazy loading

    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    33f5560 View commit details
    Browse the repository at this point in the history

  16. might not have loaded members here yet

    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    f79e2ea View commit details
    Browse the repository at this point in the history

  17. fall back to synced membership when own membership is not yet availab… 

    …le (due to lazy loading)
    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    7ea913c View commit details
    Browse the repository at this point in the history

  18. fix dm detection and conf call code with lazy loading

    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    d87d340 View commit details
    Browse the repository at this point in the history

  19. fix error/tests

    @bwindels
    bwindels committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    cfd20c7 View commit details
    Browse the repository at this point in the history