Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Replace plain text emoji at the end of a line #5878

Closed

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Apr 18, 2021

Fixes #4872

Peek 2021-04-18 10-15

Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
So it it's clear what it does

Signed-off-by: Šimon Brandner <[email protected]>
@t3chguy
Copy link
Member

t3chguy commented Apr 18, 2021

I believe #5659 is a more accessible solution to the end-of-message case, where enter is used to confirm completion, not to send message + unexpectedly confirm completion

@SimonBrandner
Copy link
Contributor Author

Ahhhhhhh, how did I manage to forget about that!? :D Yeah, that looks much better than this! 👍 What is it missing (i.e. why is it a draft)?

@SimonBrandner SimonBrandner marked this pull request as draft April 18, 2021 09:30
@t3chguy
Copy link
Member

t3chguy commented Apr 18, 2021

Stakeholder approval for such a usability change

@SimonBrandner
Copy link
Contributor Author

Ah, okay. I am going to close this in favour of #5659 and hope it gets merged in a reasonable amount of time :D

@SimonBrandner SimonBrandner deleted the fix-end-of-line-emoji branch April 18, 2021 11:01
@t3chguy
Copy link
Member

t3chguy commented Apr 18, 2021

My pr doesn't handle the newline (shift enter) case though

Will benchmark other autocompletes to see if they intercept shift enter

@t3chguy
Copy link
Member

t3chguy commented Apr 19, 2021

Discord treats shift-enter as an autocomplete confirmation
Slack just inserts a newline, I'd argue following Slack would be best and thus the newline case can be ignored as it already works as expected

@SimonBrandner SimonBrandner restored the fix-end-of-line-emoji branch September 11, 2021 08:06
@SimonBrandner SimonBrandner deleted the fix-end-of-line-emoji branch September 11, 2021 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically replace plain text Emoji doesn't work with Enter
2 participants