This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use the mimetype from the info property rather than the EncryptedFile #6591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the mimetype in EncryptedFile is undocumented and redundant. see matrix-org/matrix-spec-proposals#2582
|
This PR currently has no changelog labels, so will not be included in changelogs. Add one of: |
t3chguy
reviewed
Aug 10, 2021
Co-authored-by: Michael Telatynski <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mimetype in EncryptedFile is undocumented and redundant.
See matrix-org/matrix-spec-proposals#2582
Note: this only affects receiving events, and does not change sending the event, so it does not fix issue element-hq/element-web#17145