Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the semantics for state events sent in a thread #1285

Open
richvdh opened this issue Oct 13, 2022 · 5 comments
Open

Define the semantics for state events sent in a thread #1285

richvdh opened this issue Oct 13, 2022 · 5 comments
Labels
A-Client-Server Issues affecting the CS API improvement An idea/future MSC for the spec

Comments

@richvdh
Copy link
Member

richvdh commented Oct 13, 2022

It seems currently to be undefined what should happen if somebody sends a state event with an m.thread relationship type.

Obviously the room state will be updated (because servers will not care about the m.relates_to), but I'm concerned that clients might choose to hide the state transition in a thread, which would be confusing at best.

@richvdh
Copy link
Member Author

richvdh commented Oct 13, 2022

This seems vaguely analogous to edits of state events, which are explicitly forbidden (to avoid confusing effects like element-hq/element-web#21851)

@turt2live
Copy link
Member

the spec makes light mention of aggregations/bundles not applying to state events, so it's probably safe to say that state events can't belong in a thread.

https://spec.matrix.org/v1.4/client-server-api/#aggregations

@richvdh
Copy link
Member Author

richvdh commented Oct 13, 2022

the spec makes light mention of aggregations/bundles not applying to state events,

that would suggest that a state event can't be the root of a thread, but it could still be part of a thread, which is my concern here.

But yes, I think the only sane thing is to forbid that. It's just that we need to tell servers and clients to ignore m.thread relations on state events.

@clokep
Copy link
Member

clokep commented Oct 13, 2022

But yes, I think the only sane thing is to forbid that. It's just that we need to tell servers and clients to ignore m.thread relations on state events.

I really see no reason (with the current relation semantics) for any state event to have relations. I think I'd propose not allowing relations to a state event and not allowing state events to have relations.

@richvdh
Copy link
Member Author

richvdh commented Oct 13, 2022

I feel like I should be able to add a reaction to a state event. Not that that will work, since aggregations don't work on state events.

@turt2live turt2live added improvement An idea/future MSC for the spec A-Client-Server Issues affecting the CS API labels Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client-Server Issues affecting the CS API improvement An idea/future MSC for the spec
Projects
None yet
Development

No branches or pull requests

3 participants