New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reports that the example doesn't work anymore #83

Open

robintown opened this issue May 10, 2023 · 0 comments · May be fixed by #101

Labels

bug

Member

robintown commented May 10, 2023

https://matrix.to/#/!rDkLtgRQarvieuFHBA:t2l.io/$M5vvMdiNrsNxh4eB8_S8Z-S17TrUns3KE-qXX71dYBk?via=matrix.org&via=element.io&via=envs.net

Yes you are right. You could try to pass either the client origin (i.e. the Element URL) of "*" to the WidgetApi constructor.

The problem was introduced in version 1.2.0: Before, the targetOrigin defaulted to "*" here. That was refactored to a default value here. However, the constructor of the WidgetApi overrides it with null, so it won't work anymore.

robintown added the bug label

justinbot mentioned this issue

Fix Widget API origin in setup widget matrix-org/matrix-appservice-irc#1711

Merged

davidegirardi linked a pull request

that will close this issue

Fix example #101

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment