-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log errors during start-up and fix the default logging config #122
Conversation
@@ -210,9 +210,25 @@ def run(self): | |||
bind_addresses = self.config["http"]["bind_addresses"] | |||
pushgateway_api = PushGatewayApiServer(self) | |||
|
|||
ensureDeferred( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This in particular had me scratch my head since...it makes a Deferred
but never does anything with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc that schedules that coroutine on the Reactor (if I remember the Twisted words correctly).
One thing to note with this is that the process does exit with a success code ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm otherwise
I also added the fix for #120 to this. |
This copies (a slimmed down) version of the code we use for Synapse to log errors during start-up.
With this I'm able to get a sane error message if I have a bad config:
Fixes #121
Fixes #120