Don't try so hard, APNS — 3 times only, like GCM #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
clokep
reviewed
Jul 9, 2020
|
Thanks, this is back in review :) |
|
@reivilibre Looks like CI is being funky here? |
|
Upsy daisies, yes, this repo needed master pulling in for CI changes. :) Sorry! |
clokep
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olivier Wilkinson (reivilibre) [email protected]
This makes a minor difference so that APNS has the same retry schedule as GCM (without extra retries-per-retry).
It may still be doing too much (hopefully mitigated by #132 though)
Fixes #116