Fix race when using HTTP proxy. #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
changed the title
After `start_tls` we need to manually call `connection_made` on the protocol to tell it about the new underlying transport. This gives a brief window where the protocol can receive data without having a transport to write to, causing issues with the APNS connections where it assumes it can write once it starts reading data. We fix this by wrapping the protocol in a buffer that simply buffers incoming data until `connection_made` is called.
erikjohnston
force-pushed
the
erikj/fix_https_race
branch
from
f5e5bed
to
f368852
Compare
erikjohnston
force-pushed
the
erikj/fix_https_race
branch
from
5a3ef74
to
e66c744
Compare
clokep
approved these changes
Mar 19, 2021
It's possible there's just a lot of work queued up, or a GC happens, or some TLS session resumption that allows the server to send data immediately, or... something. I don't really know :/ |
Co-authored-by: Patrick Cloke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
start_tlswe need to manually callconnection_madeon the protocol to tell it about the new underlying transport. This gives a brief window where the protocol can receive data without having a transport to write to, causing issues with the APNS connections where it assumes it can write once it starts reading data.We fix this by wrapping the protocol in a buffer that simply buffers incoming data until
connection_madeis called.Fixes #167, hopefully