Whitelist webpush endpoints

[bwindels]

through an optional allowed_endpoints configuration key

I added support for globs because some browser vendor endpoints seem to contain sharding identifiers in the subdomain.

[clokep]

Looks good overall.

[clokep]

Does it make sense to include some info on Google/Microsoft/Mozilla here so people know what a reasonable value is?

[bwindels]

Does it make sense to include some info on Google/Microsoft/Mozilla here so people know what a reasonable value is?

Added this to the docs 👍

[bwindels]

How would I fix this error?:

sygnal/webpushpushkin.py:108: error: Incompatible types in assignment (expression has type "None", variable has type "List[Any]")  [assignment]

[clokep]

How would I fix this error?:

sygnal/webpushpushkin.py:108: error: Incompatible types in assignment (expression has type "None", variable has type "List[Any]")  [assignment]

When you define self.allowed_endpoints you need to add a type to it. I usually do this as:

self.foo = None  # type: Optional[List[str]]
if blah:
    self.foo = list(...)

You'll also need a from typing import List, Optional at the top.

[clokep]

Looks good! I think my other comment will fix the mypy issue.

[clokep]

LGTM!