Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Sentry error: RequestGenerationFailed in WebPush #205

Open
callahad opened this issue Apr 2, 2021 · 0 comments
Open

Investigate Sentry error: RequestGenerationFailed in WebPush #205

callahad opened this issue Apr 2, 2021 · 0 comments

Comments

@callahad
Copy link
Contributor

callahad commented Apr 2, 2021

Our monitoring for Syngal on matrix.org occasionally sees an error:

RequestGenerationFailed: [<twisted.python.failure.Failure builtins.AttributeError: 'FileBodyProducer' object has no attribute '_task'>]
  File "sygnal/http.py", line 265, in _handle_dispatch
    result = await pushkin.dispatch_notification(notif, d, context)
  File "sygnal/notifications.py", line 180, in dispatch_notification
    return await self._dispatch_notification_unlimited(n, device, context)
  File "sygnal/webpushpushkin.py", line 183, in _dispatch_notification_unlimited
    response = await response_wrapper.deferred
  File "twisted/internet/defer.py", line 749, in send
    raise result.value

So... what causes this to happen? Can we handle the error more gracefully?

(For Element employees, this is https://sentry.matrix.org/sentry/sygnal-matrixorg/issues/216317/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant