-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy db entirely #236
Conversation
Signed-off-by: H.Shay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I am unsure why the check_types run is failing, this check passes locally... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is close now!
- please remove
sygnal.log
:) - looks like you've been bitten by changes in Twisted (they added type annotations) which has left you with the trouble of cleaning up mypy after it. Fixing this was very noble of you, but (especially for code which you haven't touched in this PR), it's preferable to do it in a separate PR (this way, we're not waiting on this entire PR being approved before we fix CI [potentially affecting other PRs too]. It also makes reviewing this one a little bit less confusing :)). What we should have done is pin the versions of the dependencies so that this doesn't happen — if you fancy taking that on in another PR (probably using
>=...,<...
syntax so minor upgrades are still allowed? Refer to Synapse for an example), that would be appreciated and will save the next innocent person from having CI give them trouble :). - my mistake for misleading you about the
config_setup
thing -- we want to reinstate it (since it's still overridden and used by subclasses) & the calls to it from the overriding methods (in case we ever add code to the function) -- just use the wordpass
in the parent's function, because that's the standard way of saying 'this is intentionally empty' -- you could just as well write42
orsuper
but it's unusual and confused me into thinking you didn't finish the line 😅 .
98a24e3
to
8096d90
Compare
So I've made all the requested changes, and as such the CI is breaking on the types check, as expected. I opened a separate PR constraining the twisted version and fixing the type errors, perhaps we merge that and then update this branch before merging this branch? Not sure what the best way is! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a handful of minor changes now, you'll soon see this one merged and released :)
Yup, that'd be fine. I think it's likely that this will be falling into place shortly |
Signed-off-by: Dan Callahan <[email protected]>
Signed-off-by: Dan Callahan <[email protected]>
Signed-off-by: Dan Callahan <[email protected]>
...while I'm poking at Sygnal, might as well update this, too ;) |
(Note: I'm just doing rote things here, when merging please elide my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
This PR attempts to remove the (hopefully) outdated legacy DB from Sygnal, easing horizontal scaling.