Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure @matrix-org/synapse-core to be the code owner for the repo #259

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Configure @matrix-org/synapse-core to be the code owner for the repo #259

merged 1 commit into from
Oct 25, 2021

Conversation

squahtx
Copy link
Contributor

@squahtx squahtx commented Oct 22, 2021

Signed-off-by: Sean Quah [email protected]

@squahtx squahtx requested a review from a team October 22, 2021 18:15
DMRobertson
DMRobertson approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure looks to be from a call to pip, which shouldn't be affected by this change AFAICS.

@squahtx
Copy link
Contributor Author

squahtx commented Oct 25, 2021

CI is broken with pip 21.3 (released 2021-10-11), but ok with pip 21.3.1 (released 2021-10-22).
Presumably all we have to do is wait and it'll fix itself.

@squahtx squahtx merged commit 8d14a6d into main Oct 25, 2021
@squahtx squahtx deleted the squah/configure_codeowners branch October 25, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@squahtx @DMRobertson