Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the README to use Markdown rather than reStructuredText for consistency and familiarity. #278

Merged
merged 10 commits into from
Dec 6, 2021

Conversation

reivilibre
Copy link
Contributor

@reivilibre reivilibre commented Nov 29, 2021

I personally get tripped up by rST's not-quite-Markdown false friends and I also reckon that Markdown is more widely-known.

Rendered: https://github.com/matrix-org/sygnal/blob/05b2202efae4ae02994a65cc96910b66734c1898/README.md

@reivilibre reivilibre requested a review from a team as a code owner November 29, 2021 14:44
@reivilibre reivilibre changed the title Convert the README to use markdown rather than reStructuredText for consistency and familiarity. Convert the README to use Markdown rather than reStructuredText for consistency and familiarity. Nov 29, 2021
@clokep
Copy link
Member

clokep commented Nov 29, 2021

(This is also better for consistency with the rest of our projects! :))

Both synapse and sydent seem to use rST?

setup.py Show resolved Hide resolved
@reivilibre
Copy link
Contributor Author

Both synapse and sydent seem to use rST?

Gah. I don't know what planet I was on imagining that they don't...

@clokep clokep requested review from a team and removed request for clokep November 29, 2021 14:57
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong opinions on Markdown versus RST, but this looks like a sensible conversion from one to the other.

(For completeness, I had a good experience with Sphinx + autodoc + doctest + intersphinx + viewcode, so have some lingering positive emotions attributed to RST)

@reivilibre reivilibre merged commit 033d818 into main Dec 6, 2021
@reivilibre reivilibre deleted the rei/use_markdown_not_rst branch December 6, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants