Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

/sync is not bundling aggregations for limited rooms #11476

Closed
4 of 5 tasks
clokep opened this issue Dec 1, 2021 · 4 comments · Fixed by #11478 or #11659
Closed
4 of 5 tasks

/sync is not bundling aggregations for limited rooms #11476

clokep opened this issue Dec 1, 2021 · 4 comments · Fixed by #11478 or #11659
Assignees
Labels
A-Threads Threaded messages S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@clokep
Copy link
Member

clokep commented Dec 1, 2021

MSC2675 says that /sync is one of the APIs which should bundle aggregations:

GET /sync, only for room sections in the response where limited field is true; this amounts to all rooms in the response if the since request parameter was not passed, also known as an initial sync.

Currently it always disables bundled aggregations for this endpoint, see #5220.

We should also double check the other endpoints:

@clokep clokep added S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. A-Threads Threaded messages labels Dec 1, 2021
@clokep clokep self-assigned this Dec 1, 2021
@germain-gg
Copy link
Contributor

Blocks element-hq/element-web#19588

@germain-gg
Copy link
Contributor

From my tests on vector.modular.im it appears that GET /rooms/{roomId}/event/{eventId} includes the bundled relationship correctly

@clokep
Copy link
Member Author

clokep commented Dec 1, 2021

It looks like we include them in all the other places, minus the state events when calling context.

@clokep
Copy link
Member Author

clokep commented Jan 4, 2022

Reopening due to #11583.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Threads Threaded messages S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
2 participants