Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add lint targets back to lint.sh, if not configurable #12453

Closed
DMRobertson opened this issue Apr 12, 2022 · 0 comments · Fixed by #12455
Closed

Add lint targets back to lint.sh, if not configurable #12453

DMRobertson opened this issue Apr 12, 2022 · 0 comments · Fixed by #12455
Assignees
@DMRobertson
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@DMRobertson
Copy link
Contributor

A few of us have been bitten by #12420, e.g. by linting virtualenvs locally. Before, we were using the list of lint targets both to exclude unwanted lintees and include missed lintees. #12107 means that all the desired lint targets are easily discoverable by CI, but it's still convenient to exclude unwanted directories from local linting.
@DMRobertson DMRobertson self-assigned this Apr 12, 2022
@DMRobertson DMRobertson linked a pull request Apr 12, 2022 that will close this issue
Reintroduce the lint targets in the linter script #12455
Merged
@erikjohnston erikjohnston added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DMRobertson DMRobertson

Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reintroduce the lint targets in the linter script matrix-org/synapse
2 participants
@erikjohnston @DMRobertson