Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Allow users to register with a registration token without requiring registration_requires_token to be enabled #12521

Open
Half-Shot opened this issue Apr 22, 2022 · 3 comments
Labels
A-Registration Creating an account T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@Half-Shot
Copy link
Collaborator

Currently, the flow for m.login.registration_token is only valid when the config flag registration_requires_token is enabled. This means even if you have valid registration tokens available in Synapse, they won't work unless they are required by the config. This poses a problem for our system as we use these registration tokens with a Synapse module to perform special actions if the user has registered via a token.

It seems fairly harmless to allow these tokens to be used, regardless of Synapse configuration, if the admin has registered these tokens. At the very least it would be nice to differentiate between "required" and "disabled".

@H-Shay
Copy link
Contributor

H-Shay commented Apr 26, 2022

Just to clarify, what you'd like to see is an option for token registration to be enabled but not required, correct?

@H-Shay H-Shay added the X-Needs-Info This issue is blocked awaiting information from the reporter label Apr 26, 2022
@Half-Shot
Copy link
Collaborator Author

Yep, exactly that.

@H-Shay H-Shay removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Apr 26, 2022
@squahtx
Copy link
Contributor

squahtx commented Apr 27, 2022

related: #12526 Add option to enable token registration without requiring 3pids,
which added a config flag that creates a registration token flow as an alternative to required 3pids.

@H-Shay H-Shay added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Apr 27, 2022
@MadLittleMods MadLittleMods added the A-Registration Creating an account label Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Registration Creating an account T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

4 participants