Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Unread counts are broken in 1.62.0rc1 #13138

Closed
squahtx opened this issue Jun 30, 2022 · 5 comments · Fixed by #13140
Closed

Unread counts are broken in 1.62.0rc1 #13138

squahtx opened this issue Jun 30, 2022 · 5 comments · Fixed by #13140
Labels
S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Regression Something broke which worked on a previous release X-Release-Blocker Must be resolved before making a release

Comments

@squahtx
Copy link
Contributor

squahtx commented Jun 30, 2022

Unread counts for rooms are jumping to absurd numbers randomly. Other times they increment correctly.
@squahtx squahtx added P1 S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Release-Blocker Must be resolved before making a release labels Jun 30, 2022
@squahtx
Copy link
Contributor Author

squahtx commented Jun 30, 2022

changes of interest:

@reivilibre reivilibre added the X-Regression Something broke which worked on a previous release label Jun 30, 2022
@erikjohnston erikjohnston mentioned this issue Jun 30, 2022
Merged
@erikjohnston erikjohnston linked a pull request Jun 30, 2022 that will close this issue
Fix unread counts on large servers #13140
Merged
@deepbluev7
Copy link
Contributor

I think this is still happening. I get random 20 notifications in a room where there are 1 or 1 where there are 0. At first I thought it was a client bug, but I think it is just this still happening with rc2.

@erikjohnston
Copy link
Member

I think this is still happening. I get random 20 notifications in a room where there are 1 or 1 where there are 0. At first I thought it was a client bug, but I think it is just this still happening with rc2.

Can you check if there are any pending background schema updates? (By looking at background_updates table). Also note that if you were running RC1 then rooms might remain broken until you send another read receipt in the room.

@erikjohnston
Copy link
Member

This might be: #13168

@deepbluev7
Copy link
Contributor

#13168 seems to indeed have fixed it.

@kittykat kittykat added the z-p1 label Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Regression Something broke which worked on a previous release X-Release-Blocker Must be resolved before making a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unread counts on large servers matrix-org/synapse
5 participants
@kittykat @squahtx @erikjohnston @deepbluev7 @reivilibre