This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
simple_* methods handle None
incorrectly for key values
#14157
Labels
A-Database
DB stuff like queries, migrations, new/remove columns, indexes, unexpected entries in the db
O-Uncommon
Most users are unlikely to come across this or unexpected workflow
S-Minor
Blocks non-critical functionality, workarounds exist.
T-Defect
Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Generally the
simple_*
methods do not handleNone
properly when used as a key-value (the exact arguments differ by method). See #14138 for real fallout from this.simple_upsert_emulated_txn
has special handling fornull
which should likely be abstracted:synapse/synapse/storage/database.py
Lines 1304 to 1310 in b4ec4f5
This is mostly a footgun that we could avoid by either:
None
.None
and turning it intoIS NONE
(which is whatsimple_upsert_emulated_txn
does).The text was updated successfully, but these errors were encountered: