Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Document that icu is a new, optional native dependency #14704

Closed
anoadragon453 opened this issue Dec 19, 2022 · 1 comment · Fixed by #14712
Closed

Document that icu is a new, optional native dependency #14704

anoadragon453 opened this issue Dec 19, 2022 · 1 comment · Fixed by #14712
Assignees
Labels
A-Docs things relating to the documentation T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. X-Release-Blocker Must be resolved before making a release

Comments

@anoadragon453
Copy link
Member

anoadragon453 commented Dec 19, 2022

#14464 added icu as a new, optional native dependency to improve user directory search for non-English languages. If the python module is installed, then the new user search code is used, otherwise it will fall back to the old code.

We should:

  1. Update our installation instructions for native dependencies to include icu / libicu-dev.
  2. Update the UPGRADE notes to mention the new dependency. (This is the release blocker)
  3. Update the Contributing Guide to mention installing icu / libicu-dev, otherwise poetry install --extras all will fail to install pyicu.
@anoadragon453 anoadragon453 added A-Docs things relating to the documentation X-Release-Blocker Must be resolved before making a release labels Dec 19, 2022
@clokep
Copy link
Member

clokep commented Dec 19, 2022

See matrix-org/matrix-ios-sdk#1661.

@squahtx squahtx added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Dec 19, 2022
@MatMaul MatMaul self-assigned this Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Docs things relating to the documentation T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. X-Release-Blocker Must be resolved before making a release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants