Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

On my custom server, preview invitations contains matrixid instead of displayname #2124

Closed
jeangb opened this issue Apr 12, 2017 · 9 comments

Comments

@jeangb
Copy link

jeangb commented Apr 12, 2017

I use a home server recently created and not federated.
On this hs, I have user 1 and user 2, both have display names.
These both users share the same room (non public) with plenty of other users. So they should know each other display names.

To reproduce:

  1. With user1, start a new chat with user2 (on whatever client)

On user2, I'm expecting a preview invitation with the display name of user 1.
Instead the preview invitation is named with the matrix id of user1.
I won't have this problem if I use matrix.org.

@jeangb
Copy link
Author

jeangb commented Apr 12, 2017

Actually it doesn't concern only the "new chat" (Direct Message) rooms but also the normal rooms.
If a room is created, his name set up, and a user invited, this one won't see the room name but only the matrix id of the inviter.

@manuroe
Copy link
Contributor

manuroe commented Apr 18, 2017

is it an issue with the room_invite_state_types parameter in hs config?

@richvdh
Copy link
Member

richvdh commented Apr 26, 2017

@erikjohnston has promised to look at this! \o/

@manuroe
Copy link
Contributor

manuroe commented Apr 26, 2017

The issue is that, in these conditions, we do not understand why matrix.org sends several room states whereas Jean's local HS sends only one, the invite.
We tried to reuse some bits of the config file of matrix.org with no success.

@erikjohnston
Copy link
Member

@manuroe I'm not sure I follow. What differences are you seeing in the /sync responses?

@erikjohnston
Copy link
Member

Oh, I've reproduced where sync only returns the invite event:

{
  "rooms": {
    "leave": {},
    "join": {},
    "invite": {
      "!htCVufIoLwrPeOhvDL:localhost:8480": {
        "invite_state": {
          "events": [
            {
              "origin_server_ts": 1493217947194,
              "sender": "@test2:localhost:8480",
              "event_id": "$149321794732yVvhM:localhost:8480",
              "unsigned": {
                "age": 114541
              },
              "state_key": "@test:localhost:8480",
              "content": {
                "membership": "invite",
                "avatar_url": "mxc://localhost:8480/eRLOMMwLePpxziytumrHyLEB",
                "displayname": "Bob"
              },
              "membership": "invite",
              "type": "m.room.member"
            }
          ]
        }
      }
    }
  }
}

@erikjohnston
Copy link
Member

#2163

@erikjohnston
Copy link
Member

Should be fixed on develop now

@jeangb
Copy link
Author

jeangb commented Apr 28, 2017

Thanks @erikjohnston ! I'm going to test it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants