Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Switch to using official prometheus python library #3218

Closed
erikjohnston opened this issue May 15, 2018 · 1 comment
Closed

Switch to using official prometheus python library #3218

erikjohnston opened this issue May 15, 2018 · 1 comment
Assignees
Labels
z-minor (Deprecated Label) z-p2 (Deprecated Label)

Comments

@erikjohnston
Copy link
Member

The library is: https://github.com/prometheus/client_python

The advantages of doing this are:

  1. Removes custom code
  2. Gets us features for free, including the histogram/summary types
  3. Potentially allows us to host the /metrics end point on a different thread, in the hopes that if we block the reactor we will still be able to get metrics.
@neilisfragile neilisfragile added z-p2 (Deprecated Label) z-minor (Deprecated Label) labels May 17, 2018
@hawkowl hawkowl self-assigned this May 21, 2018
@hawkowl
Copy link
Contributor

hawkowl commented Jun 6, 2018

This has been done!

@hawkowl hawkowl closed this as completed Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
z-minor (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

3 participants