Improvements for Docker usage #3543
Conversation
It's much easier to build the image via docker-compose instead of an error-prone low-level docker call. Signed-off-by: Benedikt Heine <[email protected]>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
| ``` | ||
|
|
||
| The `-t` option sets the image tag. Official images are tagged `matrixdotorg/synapse:<version>` where `<version>` is the same as the release tag in the synapse git repository. | ||
| Build the docker image with the `docker-compose build` command. |
There was a problem hiding this comment.
perhaps we should document that people can skip building and specify the version where we have latest in the docker-compose file, to pull it from docker hub.
There was a problem hiding this comment.
Yes, full ACK. But my intention is to fix this later in a separate PR. This is my first one and I wanted to get the PR process known first.
This matches docker best practices. Signed-off-by: Benedikt Heine <[email protected]>
|
Hey guys, what's missing in this PR to get finally merged? |
|
Nothing as far as I can tell. @richvdh, was I supposed to merge this after approving it? I guess I did something wrong and this fell off the radar because of that. |
yes, if you're happy, please merge it :) |
Small improvement for the dockerfile to match best practices and a small improvement to make the low level docker call unnecessary.