Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

A set of improvements to the Limiter #3571

Merged
merged 4 commits into from
Jul 20, 2018
Merged

A set of improvements to the Limiter #3571

merged 4 commits into from
Jul 20, 2018

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jul 20, 2018

@richvdh
Add a sleep to the Limiter to fix stack overflows.
d7275ee 
Fixes #3570
@richvdh
Improvements to the Limiter
8462c26 
* give them names, to improve logging
* use a deque rather than a list for efficiency
@richvdh
Combine Limiter and Linearizer
7c712f9 
Linearizer was effectively a Limiter with max_count=1, so rather than
maintaining two sets of code, let's combine them.
@richvdh
changelogs
683f405
@richvdh
Copy link
Member Author

richvdh commented Jul 20, 2018

(hopefully the individual commits are easier to review than the whole thing here)

@richvdh
Copy link
Member Author

richvdh commented Jul 20, 2018

(because this renames Limiter to Linearizer, we'll need to be careful when merging to matrix-org-hotfixes, which has an extra Limiter instance)

@richvdh richvdh merged commit 4f67623 into develop Jul 20, 2018
This was referenced Jul 20, 2018
Merged
Closed
@richvdh richvdh deleted the rav/limiter_fixes branch July 26, 2018 11:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richvdh @erikjohnston