This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Allow federation_domain_whitelist to be emtpy list #3754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outbound federation were incorrectly allowed when the config option was set to an empty list
erikjohnston
force-pushed
the
erikj/fix_whitelist
branch
from
09392d4
to
c780d84
Compare
|
Frustratingly I caught one instance of this in #2820, but there were two instances of the same bug. |
richvdh
approved these changes
Aug 24, 2018
|
Wow that is bad. Is this in a release yet? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously an empty list meant that synapse wouldn't block any
federation, while it should mean to block everything.