This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Return a 404 when deleting unknown room alias #3889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
suggested changes
Sep 17, 2018
synapse/handlers/directory.py
Outdated
| @@ -320,7 +333,7 @@ def can_modify_alias(self, alias, user_id=None): | |||
| def _user_can_delete_alias(self, alias, user_id): | |||
| creator = yield self.store.get_room_alias_creator(alias.to_string()) | |||
|
|
|||
| if creator and creator == user_id: | |||
| if creator == user_id: | |||
There was a problem hiding this comment.
I don't think this null check can be removed as the creator column was added at a later date, so there is not guarantee it'll exist.
erikjohnston
approved these changes
Sep 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per matrix-org/matrix-spec-proposals#1675
Fixes #2782