This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix some instances of ExpiringCache not expiring cache items #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExpiringCache required that `start()` be called before it would actually start expiring entries. A number of places didn't do that. This PR removes `start` from ExpiringCache, and automatically starts backround reaping process on creation instead.
|
This seems to help quite a bit on jki.re, but we might want to consider adding a bit of jitter so that we don't end up with the entire cache being invalidated at once |
this sounds like an orthogonal problem. |
richvdh
approved these changes
Sep 25, 2018
I wonder which... |
richvdh
pushed a commit
that referenced
this pull request
Sep 26, 2018
It used to try and produce an estimate, which was sometimes negative. This caused metrics to be sad, so lets always just calculate it from scratch. (This appears to have been a longstanding bug, but one which has been made more of a problem by #3932 and #3933). (This was originally done by Erik as part of #3933. I'm cherry-picking it because really it's a fix in its own right)
richvdh
added a commit
that referenced
this pull request
Sep 28, 2018
I think this got forgotten in #3932. We were getting away with it because it was the last call in this function.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpiringCache required that
start()be called before it would actuallystart expiring entries. A number of places didn't do that.
This PR removes
startfrom ExpiringCache, and automatically startsbackround reaping process on creation instead.