This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Only colourise synctl output when attached to tty #4049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/synctl_colour
branch
from
0703d1f
to
1af16ac
Compare
richvdh
reviewed
Oct 17, 2018
synctl
Outdated
| if colour == NORMAL: | ||
| # Lets check if we're writing to a TTY before colouring | ||
| should_colour = False | ||
| if stream in (sys.stdout, sys.stderr): |
There was a problem hiding this comment.
could you just catch the AttributeError instead?
There was a problem hiding this comment.
(and maybe not even bother checking if colour==NORMAL)
… bother checking colour==Normal
hawkowl
approved these changes
Oct 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably not be hand rolling this, but I don't want to get lost in a rabbithole of replacing with a proper library.