Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Update Dependencies #4399

Merged
merged 3 commits into from
Jan 16, 2019
Merged

Update Dependencies #4399

merged 3 commits into from
Jan 16, 2019

Conversation

andrewshadura
Copy link
Contributor

@andrewshadura andrewshadura commented Jan 16, 2019 •
edited
Loading

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off

@andrewshadura andrewshadura changed the title WIP: Update Dependencies Update Dependencies Jan 16, 2019
@andrewshadura
Use msgpack instead of msgpack-python
fab9481 
The package msgpack-python has been deprecated.

Signed-off-by: Andrej Shadura <[email protected]>
@andrewshadura
Depend on pymacaroons >= 0.13.0 instead on pymacaroons-pynacl
64cf678 
Since 0.13.0, pymacaroons works correctly with pynacl, so there
isn’t any more reason to depend on an outdated pynacl fork.

Signed-off-by: Andrej Shadura <[email protected]>
@andrewshadura
Add a changelog entry
3b31a54 
Signed-off-by: Andrej Shadura <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #4399 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4399   +/-   ##
========================================
  Coverage    73.65%   73.65%           
========================================
  Files          300      300           
  Lines        29815    29815           
  Branches      4897     4897           
========================================
  Hits         21960    21960           
+ Misses        6414     6412    -2     
- Partials      1441     1443    +2
Impacted Files Coverage Δ
synapse/python_dependencies.py 45.83% <ø> (ø) ⬆️
synapse/handlers/search.py 80.24% <0%> (ø) ⬆️
synapse/handlers/federation.py 61.72% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa955f2...3b31a54. Read the comment docs.

erikjohnston
erikjohnston approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks entirely sane, as both packages say they are deprecated in favour of the new ones.

@erikjohnston
Copy link
Member

Thanks!

@erikjohnston erikjohnston merged commit 7f1a6a4 into matrix-org:develop Jan 16, 2019
@erikjohnston erikjohnston mentioned this pull request Jan 16, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewshadura @codecov-io @erikjohnston