Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

UPSERT many functionality #4644

Merged
merged 14 commits into from
Feb 20, 2019
Merged

UPSERT many functionality #4644

merged 14 commits into from
Feb 20, 2019

Conversation

hawkowl
Copy link
Contributor

@hawkowl hawkowl commented Feb 14, 2019

No description provided.

@hawkowl hawkowl requested a review from a team February 14, 2019 14:38
@codecov-io
Copy link

codecov-io commented Feb 14, 2019

Codecov Report

Merging #4644 into develop will increase coverage by 0.01%.
The diff coverage is 65.85%.

@@             Coverage Diff             @@
##           develop    #4644      +/-   ##
===========================================
+ Coverage    75.14%   75.16%   +0.01%     
===========================================
  Files          340      340              
  Lines        34767    34803      +36     
  Branches      5683     5700      +17     
===========================================
+ Hits         26126    26160      +34     
+ Misses        7035     7033       -2     
- Partials      1606     1610       +4

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks generally great. A few nitpicks

.travis.yml Outdated Show resolved Hide resolved
synapse/storage/_base.py Outdated Show resolved Hide resolved
synapse/storage/_base.py Outdated Show resolved Hide resolved
synapse/storage/_base.py Outdated Show resolved Hide resolved
synapse/storage/_base.py Outdated Show resolved Hide resolved
@hawkowl hawkowl requested a review from a team February 19, 2019 20:35
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hawkowl hawkowl merged commit a06614b into develop Feb 20, 2019
@hawkowl hawkowl deleted the hawkowl/upsert-many branch May 21, 2019 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants