This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Handle errors when fetching remote server keys #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4722 +/- ##
===========================================
- Coverage 75.15% 75.14% -0.02%
===========================================
Files 340 340
Lines 34823 34840 +17
Branches 5704 5707 +3
===========================================
+ Hits 26171 26179 +8
- Misses 7042 7050 +8
- Partials 1610 1611 +1 |
richvdh
reviewed
Feb 25, 2019
synapse/crypto/keyring.py
Outdated
| long_retries=True, | ||
| ) | ||
| except (NotRetryingDestination, RequestSendFailed) as e: | ||
| raise raise_from( |
There was a problem hiding this comment.
I think the raise is redundant here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.