This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Limit cache invalidation replication line length #4748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
suggested changes
Feb 26, 2019
synapse/storage/_base.py
Outdated
| # We need to be careful that the size of the `members_changed` list | ||
| # isn't so large that it causes problems sending over replication, so we | ||
| # send them in chunks. | ||
| members_changed = list(members_changed) |
There was a problem hiding this comment.
I think you want synapse.util.batch_iter here.
synapse/storage/_base.py
Outdated
| # isn't so large that it causes problems sending over replication, so we | ||
| # send them in chunks. | ||
| members_changed = list(members_changed) | ||
| for i in range(0, len(members_changed), 100): |
There was a problem hiding this comment.
given that mxids have a maxlen of 255 chars, we can still easily overflow the max line length of 16K
Codecov Report
@@ Coverage Diff @@
## develop #4748 +/- ##
===========================================
- Coverage 75.12% 75.11% -0.01%
===========================================
Files 340 340
Lines 34860 34867 +7
Branches 5711 5713 +2
===========================================
+ Hits 26188 26190 +2
- Misses 7058 7062 +4
- Partials 1614 1615 +1 |
|
Hopefully fixes #4733 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where replication completely wedges if the server tries to send a cache invalidation that serialises to a line that is longer than the max line length.
Introduced in #4671