This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix v4v6 option in HAProxy example config #4790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v4v6 option only has a usage one ipv6 socket: https://serverfault.com/q/747895 Signed-off-by: Flakebi <[email protected]>
|
looks plausible. @benpro can you confirm? |
Codecov Report
@@ Coverage Diff @@
## develop #4790 +/- ##
==========================================
- Coverage 75.13% 75.1% -0.03%
==========================================
Files 340 340
Lines 34918 34918
Branches 5722 5722
==========================================
- Hits 26234 26224 -10
- Misses 7072 7081 +9
- Partials 1612 1613 +1 |
|
@richvdh Yes indeed (was an error of mine). LGTM. |
|
thanks both! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v4v6 option only has a usage one ipv6 socket: https://serverfault.com/q/747895
Signed-off-by: Flakebi [email protected]
Pull Request Checklist